electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

github actions tag

Open nanamicat opened this issue 1 year ago • 1 comments

  • Electron-Builder Version: 23.3.3
  • Node Version: v8.7.0
  • Electron Version:20.0.1
  • Electron Type (current, beta, nightly):current
  • Target: all

in github actions, electron-builder can't get current tag. onTag and onTagOrDraft publish policy not works.

function getCiTag() {
    const tag = process.env.TRAVIS_TAG || process.env.APPVEYOR_REPO_TAG_NAME || process.env.CIRCLE_TAG || process.env.BITRISE_GIT_TAG || process.env.CI_BUILD_TAG || process.env.BITBUCKET_TAG;
    return tag != null && tag.length > 0 ? tag : null;
}

https://docs.github.com/en/actions/learn-github-actions/environment-variables should check GITHUB_REF_TYPE == 'tag' and return GITHUB_REF

nanamicat avatar Aug 16 '22 04:08 nanamicat

Please open a PR adding that logic to the function :)

mmaietta avatar Aug 17 '22 00:08 mmaietta