electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

Published 20 hours ago • verified publisher icon electron-userland

Allow override `isSuitableWindowsTarget` for customized auto-updater

Open haoxi911 opened this issue 3 years ago • 1 comments

  • Electron-Builder Version: 23.1.0
  • Node Version: 16.14.0
  • Electron Version: 19.0.4
  • Electron Type (current, beta, nightly): current
  • Target: Windows

On Windows, the app-update.yml and latest.yml files will only be created with nsis target, however, for those who are delivering portable Electron app, they won't be able to target to nsis, usually they will target to zip.

Even though electron-updater is not using Squirrel.Windows and won't be able to install the downloaded zip package, we as developers can create separate utility app to perform the installation (i.e. extract the zip to target folder).

isSuitableWindowsTarget method in PublishManager.ts prevents us from doing this level of customization. Maybe we should export this method so that people like me can override it from outside.

haoxi911 avatar Jun 28 '22 23:06 haoxi911

electron-updater is not using Squirrel.Windows and won't be able to install the downloaded zip package, we as developers can create separate utility app to perform the installation

Not sure how complex this would be, but would you be willing to contribute to electron-updater and add that functionality?

mmaietta avatar Jul 04 '22 03:07 mmaietta