Snapstore publish method deprecated

[andirsun]

17.3.0

• Electron-Builder Version: 23.0.2

• Node Version: v14.x

• Electron Version: v17.3.0
• Electron Type (current, beta, nightly): current

• Target: Linux - Snap

I am releasing my linux app to snapstore and the electron-builder command shows this deprecations:

DEPRECATED: The 'push' set of commands have been replaced with 'upload'.
See http://snapcraft.io/docs/deprecation-notices/dn11 for more information.

[mmaietta]

Please open a ticket at https://github.com/develar/app-builder

The snapstore publishing logic is in that upstream binary.

[AdrianoFerrari]

There's a PR waiting to be merged that fixes this... any chance it could be merged soon, @mmaietta ? https://github.com/develar/app-builder/pull/80

It's no longer a warning, but a build failure. And it seems like a pretty straightforward change... Snapcraft is at 7.x right now, and I'd prefer not downgrading to 3.x just to fix this one issue, if possible :slightly_smiling_face:.

[mmaietta]

I don't manage app-builder and honestly, don't understand the code either.

Also, it's broken AppImage assembly in 4.1.x so we're effectively screwed from updating unless someone fixes it Ref: https://github.com/electron-userland/electron-builder/issues/6678.

As a pointer to anyone looking to fix it and unblock electron-builder, I suspect the commit that broke app-builder was https://github.com/develar/app-builder/commit/c24d1b50fbd313650ccab2021945eb006a39f0ae Specifically:

func GetAppImageToolDir() (string, error) {
-	dirName := "appimage-12.0.1"
+	dirName := "appimage-13.0.0"

But I have no idea how to test that hypothesis

[Nantris]

Is this still a problem? It seems to be fixed upstream: https://github.com/develar/app-builder/pull/80

[mmaietta]

The problem is in this PR: https://github.com/electron-userland/electron-builder/pull/7774

I can't update the app-builder package as something is awry with the changes that were made. Excerpt of test failure

posix smart unpack

    ENOENT: no such file or directory, scandir '/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-2ACDjf/test-project-9/node_modules/are-we-there-yet/node_modules/core-util-is'

I think it has to do with symlink changes, but honestly, I'm not familiar enough with Go to try and implement a fix.

[Nantris]

Strange. I asked because I'd had trouble getting Snap working for unrelated reasons - but since then I've been able to get publishing working (at least to the edge channel.)