electron-builder
electron-builder copied to clipboard
[email protected]: Disk image license agreements are deprecated by Apple and will probably be removed in a future macOS release.
- Electron-Builder Version: 23.0.0
- Node Version: 16.6.1
- Electron Version: 11.5.0
- Electron Type (current, beta, nightly): current
- Target: macOS 12.0.1 Universal
Full warning message:
warning electron-builder > dmg-builder > [email protected]: Disk image license agreements are deprecated by Apple and will probably be removed in a future macOS release. Discussion at: https://github.com/argv-minus-one/dmg-license/issues/11
This message started within the past day.
Yep, discussion has been kickstarted in https://github.com/argv-minus-one/dmg-license/issues/11
We'll track it, but there's not much we can do for now.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Will this stop the distribution of DMG builds?
@mmaietta would it be worth considering inlining the dmg-license dependency to stop the warning and instead show a more severe warning for code paths that actually use writePlistToDmg
to attach a license?
Hmmm. What do you mean by inlining the dependency?
Copy the code so it's part of the this repro and npm install
stops showing the deprecation warning. Then add a different warning specific to code using the feature.
@argv-minus-one, are you okay with that approach? ☝️
No need. I've gone ahead and un-deprecated dmg-license.
I don't like it, as people really need to stop using it ASAP and that was the best way I could think of to make that happen, but if it drives people to inline the whole package just to get rid of the warning, then that's not good either.