NSIS one click installer uses package name for install directory not productName

[Krelborn]

• Version: 22.4.1
• Target: NSIS

When installing on Windows with the one click NSIS installer, the application gets installed to a directory which is named using the name key from the npm package.json rather than using the productName. If I set the one click option to false, the directory is named correctly. The actual user data for is always stored in a folder named using productName.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Krelborn]

Is anyone able to comment on this?

[mahnunchik]

I think it may be related https://github.com/electron-userland/electron-builder/issues/4933

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[mahnunchik]

It is still relevant!

[Krelborn]

It's not been fixed as of the latest version.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[mahnunchik]

пт, 25 сент. 2020 г., 14:04 stale[bot] [email protected]:

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/electron-userland/electron-builder/issues/4803#issuecomment-698867882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF6VB55GBHQTG7IVBAV3DDSHR2NNANCNFSM4LQL5A7Q .

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[mahnunchik]

relevent

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[mahnunchik]

https://github.com/electron-userland/electron-builder/issues/4803#issuecomment-766321788

[tessro]

We are running into this too. Disabled oneClick for now. 😢

[tessro]

It's caused by the second parameter to getWindowsInstallationDirName, here: https://github.com/electron-userland/electron-builder/blob/da85087143d2c6a63faab4c44c28dc625326e9ee/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts#L167

I tried to trace this back to understand the rationale, but it's a very old change and the file has been moved in git since it was implemented this way.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[mahnunchik]

https://github.com/electron-userland/electron-builder/issues/4803#issuecomment-853177497

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[tomasklaen]

Well, I'm dealing with this issue too. The nsis installs the app into AppData/Local/Programs/{manifest.name} instead of the desired AppData/Local/Programs/{manifest.productName}, even though the productName is just a PascalCased name.

On the other hand, the user data folder the app creates is the desired AppData/Roaming/{manifest.productName}, so the app is now inconsistent in how it names its folders.

But I guess the stale bot has won :(

[tom-leamon]

This needs to be un-marked as stale. This is still a persistent and relevant issue. @mmaietta

[end3rbyte]

Yes I confirm this issue is still there and very annoying. It should use the productName

[m1rn]

Well, I'm dealing with this issue too. The nsis installs the app into AppData/Local/Programs/{manifest.name} instead of the desired AppData/Local/Programs/{manifest.productName}, even though the productName is just a PascalCased name.

On the other hand, the user data folder the app creates is the desired AppData/Roaming/{manifest.productName}, so the app is now inconsistent in how it names its folders.

But I guess the stale bot has won :(

I just noticed this issue as well. Have you found a solution?

[p2004a]

I've run into this today but I think I have a workaround, at least so far everything seems to be working fine:

Add a Custom NSIS script that looks like:

!macro customHeader
  ; Workaround for https://github.com/electron-userland/electron-builder/issues/4803
  !define /redef APP_FILENAME "YourProductName"
!macroend

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.

[tom-leamon]

This issue should not be closed until it has been fixed.

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.

[p2004a]

This issue should not be closed until it has been fixed.

[mmaietta]

Community PRs are always welcome. I'm personally not the most familiar with Windows, so a community assistance on this would be greatly appreciated