electron-builder-binaries icon indicating copy to clipboard operation
electron-builder-binaries copied to clipboard

How to update / upgrade NSIS

Open Simon-Laux opened this issue 4 years ago • 2 comments

We have an issue where the installer is crashing sometimes (when the user directory contains spaces) before doing anything. https://github.com/deltachat/deltachat-desktop/issues/1269

I tried understanding the scripts but I currently don't have the time to find out how exactly everything works.

Can you describe what I need to do to make a build for or provide builds for:

  • the current nsis release (3.0.6.1 at the time of writing)
  • the current nsis master/nightly/next-release (3.0.7 at the time of writing)

I want to test if these new versions of NSIS can fix the issue.

Simon-Laux avatar Jul 09 '21 12:07 Simon-Laux

I tried to figure this one out as well but didn't manage to get far on Windows. There are these scripts that have hints as to what needs to be done https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis-prepare.sh https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis.sh https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis-linux.sh

I could use an updated one for my PR adding debug logging to nsis installers https://github.com/electron-userland/electron-builder/pull/6024

mmaietta avatar Jul 28 '21 00:07 mmaietta