libDaisy icon indicating copy to clipboard operation
libDaisy copied to clipboard
verified publisher icon electro-smith

Remove WM8731 TODO comment

Open jacobvosmaer opened this issue 1 year ago • 1 comments

I was reading the WM8731 audio codec setup code and I got confused by a comment which suggested Daisy always uses the codec with a 48kHz sample rate. After several hours of reading data sheets I figured out what is going on here: the WM8731 has built-in sample rate conversion and the nominal "48kHz" setting disables the built-in conversion.

This commit updates the comment to explain what we are actually doing here.

jacobvosmaer avatar Apr 04 '24 09:04 jacobvosmaer

Looks good, nice catch!

beserge avatar May 09 '24 19:05 beserge