libDaisy icon indicating copy to clipboard operation
libDaisy copied to clipboard

Published 20 hours ago • verified publisher icon electro-smith

Feature/add editorconfig file

Open TheSlowGrowth opened this issue 2 years ago • 4 comments

This is a proposal to add an .editorconfig file that can automatically configure code editors to use the recommended settings for this repository.

  • Add .editorconfig file
  • Add editorconfig extension to the recommended VSCode extensions
  • ~~Add a check to the style workflow that enforces the formatting~~
  • Format all relevant files to the editorconfig settings (mostly removing trailing spaces)

TheSlowGrowth avatar Jul 19 '22 16:07 TheSlowGrowth

okay, that github action is clearly not maintained anymore. I'll search for a replacement we can use. In the worst case, we could also choose to not verify the formatting on CI.

TheSlowGrowth avatar Jul 19 '22 16:07 TheSlowGrowth

Okay, I removed the github action for now. There doesn't seem to be a readily available action that works :-(

TheSlowGrowth avatar Jul 19 '22 17:07 TheSlowGrowth

Side note -- holy cow, there was so much trailing white space in the comments!! 😱

stephenhensley avatar Jul 19 '22 20:07 stephenhensley

Hi @TheSlowGrowth

Sorry for the huge delay in getting to this one. Last time I looked this over, I don't think I realized it was ready to review/merge due to the comments about the github action.

Happy to review/merge this if it's ready (looks like the conflicts are all fairly trivial atm).

stephenhensley avatar Jun 20 '23 20:06 stephenhensley