DaisySP icon indicating copy to clipboard operation
DaisySP copied to clipboard

Published 20 hours ago • verified publisher icon electro-smith

Adenv crashes with segment times = 0

Open andrewikenberry opened this issue 4 years ago • 4 comments

As dicussed on the Daisy forum.

andrewikenberry avatar Oct 28 '20 17:10 andrewikenberry

Fix AdEnv non-zero issue

andrewikenberry avatar Oct 28 '20 19:10 andrewikenberry

This should have been fixed with my remake, which has been merge recently.

sdiedrichsen avatar Jun 08 '21 17:06 sdiedrichsen

I'm having some issues with the ADenv as it is right now:

  • with long release times, a decay tied to a pot (via parameter) will sometimes get "stuck" and keep passing the audio through;
  • with very short times close to 0.0 (e.g. 0.0001) and other DSP load going on, I get audio glitches that are gone at more moderate, "middle of the road" segment times

A suggestion (as discussed in the electrosmith slack) would be to apply @sdiedrichsen 's ADSR fix to the ADenv as well: https://github.com/electro-smith/DaisySP/pull/160

makingsoundmachines avatar Jul 26 '21 16:07 makingsoundmachines

A lower limit for segment values of 0.0005 (for ADENV_SEG_ATTACK / ADENV_SEG_DECAY) fixed the issues I was having.

makingsoundmachines avatar Jul 26 '21 21:07 makingsoundmachines