electricitymaps-contrib icon indicating copy to clipboard operation
electricitymaps-contrib copied to clipboard

"Installed capacity" label is shown for aggregated data

Open corradio opened this issue 1 year ago • 2 comments

Describe the bug "Installed capacity" label should not be shown for aggregated data

To Reproduce Steps to reproduce the behavior:

  1. Pick any zone
  2. Select Yearly view

Expected behavior "Installed capacity" label should not be shown for aggregated data.

Screenshots image

corradio avatar Oct 14 '24 16:10 corradio

Let's see if someone want to fix this as a part of Hacktoberfest otherwise I'll pick it up. 👍🏼

VIKTORVAV99 avatar Oct 14 '24 16:10 VIKTORVAV99

I am happy to work on it as part of Hacktoberfest, if it is still available

Should the label removal apply for daily, monthly, and yearly? (except the hourly, because it has the relevant data => capacitySources)

https://github.com/electricitymaps/electricitymaps-contrib/blob/c2796b5d8fb35741c112e2ad6d6f593796a2897b/web/src/features/charts/bar-breakdown/BarBreakdownChart.tsx#L143

Reterics avatar Oct 15 '24 16:10 Reterics

I am interesting in picking up this issue, can this be assigned to me.

Nivedhitha-dp avatar Nov 07 '24 01:11 Nivedhitha-dp

I am interesting in picking up this issue, can this be assigned to me.

Sure thing, please try and do it in a way that don't cause CLS when shifting between the aggregations.

VIKTORVAV99 avatar Nov 07 '24 14:11 VIKTORVAV99