electricitymaps-contrib icon indicating copy to clipboard operation
electricitymaps-contrib copied to clipboard

Published 20 hours ago • verified publisher icon electricitymaps

Added emission factors for Ontario

Open Nil-Cipher opened this issue 1 year ago • 10 comments

Issue

Closes #4886

Description

Added emission numbers for various electricity generation types for Ontario.

Double check

  • [x] I have run pnpx prettier --write . and poetry run format to format my changes.

Nil-Cipher avatar Jun 28 '23 01:06 Nil-Cipher

@VIKTORVAV99 made PR for review!

Nil-Cipher avatar Jun 28 '23 01:06 Nil-Cipher

Copied the original source text. @VIKTORVAV99

Nil-Cipher avatar Jun 28 '23 17:06 Nil-Cipher

@VIKTORVAV99 should be good now.

Nil-Cipher avatar Jul 08 '23 14:07 Nil-Cipher

I'll try and take a look later today. 👍🏼

VIKTORVAV99 avatar Jul 08 '23 14:07 VIKTORVAV99

@VIKTORVAV99 updates? I'm not sure why the prettier check is pending.

Nil-Cipher avatar Jul 29 '23 22:07 Nil-Cipher

Ah sorry @Nil-Cipher this slipped under my radar when doing all the dependabot dependency updates. I'll take a look at it later today.

Prettier and the other CI checks where pending as they need approval to run if you have not contributed before, but now you have so they run as expected. (It's a github anti bot measure)

VIKTORVAV99 avatar Aug 05 '23 11:08 VIKTORVAV99

@VIKTORVAV99 Should be good now!

Nil-Cipher avatar Aug 10 '23 01:08 Nil-Cipher

Why did you add back the weird double quotes and wrap it in single quotes again? This should not be needed for YAML.

(the doi link is also back in the values for the emission factors).

Hm, maybe I merged things in the wrong order, sorry about this. The double quotes could be a formatting thing, I didn't add them intentionally.

Nil-Cipher avatar Aug 13 '23 01:08 Nil-Cipher

Okay, this should not have been this painful, but I think it is good.

Nil-Cipher avatar Aug 13 '23 01:08 Nil-Cipher

Seems like I missed the last change in here and I'm sorry about that.

But this has been resolved in another PR now so closing this one.

(A tip for the future is to re-request a review after changes, it's hard to keep up with all the "normal" notifications from GitHub and review requests end up automatically in my tools so they are easier to keep track of.)

VIKTORVAV99 avatar Oct 13 '23 14:10 VIKTORVAV99