electric icon indicating copy to clipboard operation
electric copied to clipboard

chore: Refactor shape_id -> shape_handle for clearer name

Open KyleAMathews opened this issue 1 year ago • 1 comments

Addresses one of the renames proposed in https://github.com/electric-sql/electric/issues/1771

  • [ ] rename shapeId as well

KyleAMathews avatar Oct 04 '24 15:10 KyleAMathews

Deploy Preview for electric-next ready!

Name Link
Latest commit 773c2aa4c1bd77942bd18b5a0771278bbaa26694
Latest deploy log https://app.netlify.com/sites/electric-next/deploys/6720a4f508bb140008f97524
Deploy Preview https://deploy-preview-1796--electric-next.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 04 '24 15:10 netlify[bot]

Yeah either way it'll be annoying to rebase... I don't care which way we go.

KyleAMathews avatar Oct 23 '24 17:10 KyleAMathews

Is anything left in this PR? Let's merge it if not.

Needs to be coordinated with https://github.com/electric-sql/electric/pull/1833

balegas avatar Nov 04 '24 09:11 balegas

I want to say this is superseded by #1900. Although I'm not super hot on git foo so just to be clear: I rebased that PR on this one. So I'm not sure do we need to merge this PR if we merge that one, or not? I guess we can just merge #1900?

thruflo avatar Nov 04 '24 09:11 thruflo

Superseded by #1900

icehaunter avatar Nov 05 '24 16:11 icehaunter