electric
electric copied to clipboard
chore: Refactor shape_id -> shape_handle for clearer name
Addresses one of the renames proposed in https://github.com/electric-sql/electric/issues/1771
- [ ] rename
shapeIdas well
Deploy Preview for electric-next ready!
| Name | Link |
|---|---|
| Latest commit | 773c2aa4c1bd77942bd18b5a0771278bbaa26694 |
| Latest deploy log | https://app.netlify.com/sites/electric-next/deploys/6720a4f508bb140008f97524 |
| Deploy Preview | https://deploy-preview-1796--electric-next.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Yeah either way it'll be annoying to rebase... I don't care which way we go.
Is anything left in this PR? Let's merge it if not.
Needs to be coordinated with https://github.com/electric-sql/electric/pull/1833
I want to say this is superseded by #1900. Although I'm not super hot on git foo so just to be clear: I rebased that PR on this one. So I'm not sure do we need to merge this PR if we merge that one, or not? I guess we can just merge #1900?
Superseded by #1900