basicLightbox

basicLightbox copied to clipboard

Managing focus

9

Looking at the demos it looks like there is some focus management missing on the modals. Here's what needs to be added to fix it: * When a modal is...

acnorrisuk

<picture> tag support

1

I am trying to add support for webp image formats with jpg fallbacks. When I write my listener like this the lightbox works as intended: ``` window.addEventListener('load', (event) => {...

akhost

Fixed behavior with tag <picture>: images now get resized.

2

8lall0

Height 100vh is too tall on iOS Safari

2

On iOS Safari, if the two navigation bars are shown, 100vh is actually taller than the screen area available. So if you make a scrollable popup, it won't be possible...

ArianeNubee

Listen for transition end

3

You're using `requestAnimationFrame` two times but without changing dom propriety from javascript. I don't see how this can improve performance as you add class to animate dom element. I can...

jimblue

Demo for srcset support

4

A demo for srcset support would be great!

strarsis

#45 extend Option with (optional) "container" parameter which can be …

1

…used to specify the container the overlay should be attached to

LOK-Soft

In order to allow different styling (e.g. not overlaying to whole page but only a part of it) it would be good to have the possibility to pass the container...

LOK-Soft