basicGrid icon indicating copy to clipboard operation
basicGrid copied to clipboard

hide-on & show-on seem to break anything that isn't set as display block

Open Shrinks99 opened this issue 5 years ago • 1 comments

When using hide-on and show-on to change the visibility of an element set to display: flex; it seems to override the existing display mode and set it to block which is undesired. Setting show-on to display: inherit seems to have fixed this for me but I don't feel confident enough in my CSS skills to just go and submit a PR for this issue!

Would appreciate it if somebody a little more knowledgeable wouldn't mind testing this ;P

Shrinks99 avatar Jan 13 '20 07:01 Shrinks99

.show-on- changes the rows to flex and the columns to block (https://github.com/electerious/basicGrid/blob/master/src/styles/_mixins.scss). This might be problematic if you're overwriting some styling of the grid.

Changing it to display: inherit might work for columns, but I've uses basicGrid in so may projects I seriously can't tell if this works in all cases.

I will give it a try by time!

electerious avatar Jan 13 '20 09:01 electerious