Neil Horne

Results 138 comments of Neil Horne

@philmoz First thoughts. - overall looks okay. - have you checked binary conversions to ensure they are not offset by the inverted entries? - am I correct in assuming: --...

Will the choice of '!' to signify inverted be confusing as we currently use it to signify 'not' for switches?

> I don't have any files to test this with; but I don't believe there would be any issue. The only place I know of where a negative 'source' value...

> Any thoughts on this as an alternative for the source UI? Me no like. It would also mean adding the inverted checkbox to every source usage case in the...

> There aren't that many of them so it's not a huge effort. It also means we don't need two models for the popup list. I haven't thought this through...

> BFI. I don't know QT well enough to do that. I can do that if there is a need. Also having a separate check box means we couldn't use...

> Using a negative value for RawSource index won't work (I tried this initially). The index value for a each source type always starts at 0 and since -0 ==...

I need to 'merge' #4735 into this one

Merge of 4735 done