raspi-pico-aprs-tnc icon indicating copy to clipboard operation
raspi-pico-aprs-tnc copied to clipboard

Fix dangling refs

Open ArkinSolomon opened this issue 7 months ago • 1 comments
trafficstars

Fixes #3

ArkinSolomon avatar Apr 08 '25 06:04 ArkinSolomon

Hi Arkin, thanks for your patch ! However, instead of moving the definitions of the struct instances into file scope, I'd prefer to leave them in their function scope, because the latter is narrower. Instead, I'd declare both struct instances as "static" to achieve program lifetime. I realized that this was also done in the reference code, but obviously, I ignored that for any reason ... What do you think ?

eleccoder avatar Apr 08 '25 20:04 eleccoder

Fixed by commit 097b411ae96362072d6ca8354de15d1606d3728e

eleccoder avatar Jul 23 '25 16:07 eleccoder