RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

Added the story mode with 2 methods and add min comment lenght

Open electro199 opened this issue 3 years ago • 5 comments

Added the story mode with two options! The first option is only a screenshot of the post description (looks ugly with long posts). The second option generates images for every sentence.

I also added minimum comment length sorting feature

Checklist:

  • [x] I am pushing changes to the develop branch
  • [x] I am using the recommended development environment
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have formatted and linted my code using python-black and pylint
  • [x] I have cleaned up unnecessary files
  • [ ] My changes generate no new warnings
  • [x] My changes follow the existing code-style
  • [x] My changes are relevant to the project

Any other information (e.g how to test the changes)

It's a big feature and it needs to be tested a lot.

electro199 avatar Oct 06 '22 11:10 electro199

I have solve conflicts

electro199 avatar Oct 06 '22 12:10 electro199

Try using https://moviepy-tburrows13.readthedocs.io/en/latest/_modules/moviepy/video/fx/scroll.html

Instead of multiple screenshots

JasonLovesDoggo avatar Oct 11 '22 16:10 JasonLovesDoggo

Try using https://moviepy-tburrows13.readthedocs.io/en/latest/_modules/moviepy/video/fx/scroll.html

Instead of multiple screenshots

yes possible it looks more like comment mode that's why I choose this approach

electro199 avatar Oct 11 '22 18:10 electro199

When will this be released? Or How can I at least get the beta version of this to be working?

ahelby avatar Oct 15 '22 15:10 ahelby

When will this be released? Or How can I at least get the beta version of this to be working?

Hey, I hope we can release this soon. But it needs to be tested a lot because it's a big feature. I would recommend to join Lewis' Discord server, more information about testing the story mode is there!

OpenSourceSimon avatar Oct 15 '22 15:10 OpenSourceSimon

I definitely agree with Simon here

JasonLovesDoggo avatar Nov 11 '22 16:11 JasonLovesDoggo

Awesome PR, can't test it right now. Could you look at the things that I commented on? When that's fixed, I'll be happy to test it.

ok i will consider it

electro199 avatar Nov 11 '22 19:11 electro199

I'll commit some code which mostly includes reformatting from Black and a couple of bug fixes. There definitely needs to be a check for posts that don't support story mode, when story mode is enabled.

OpenSourceSimon avatar Nov 20 '22 11:11 OpenSourceSimon

first it says this:

'ffmpeg' is not recognized as an internal or external command

then this:

\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\moviepy\video\io\ffmpeg_reader.py", line 270, in ffmpeg_parse_infos raise IOError(("MoviePy error: the file %s could not be found!\n" OSError: MoviePy error: the file assets/temp/z0x8ye/mp3/title.mp3 could not be found! Please check that you entered the correct path.

if you need more traceback let me know.

gabx03 avatar Nov 21 '22 19:11 gabx03

I managed to fix that and now i get 'File not found: assets/temp/id/mp3/part.mp3' while using TikTok TTS, because no mp3 files were being created. Probably because TikTok TTS is deprecated at the current version. Then 'waiting for selector "#t1_ixbkbc2' while using pytts, because mp3 files were being created at least. @electro199

gabx03 avatar Nov 22 '22 14:11 gabx03

I managed to fix that and now i get 'File not found: assets/temp/id/mp3/part.mp3' while using TikTok TTS, because no mp3 files were being created. Probably because TikTok TTS is deprecated at the current version. Then 'waiting for selector "#t1_ixbkbc2' while using pytts, because mp3 files were being created at least. @electro199

The TikTok TTS currently doesn't work. Try streamlabspolly or Google Translate

OpenSourceSimon avatar Nov 22 '22 14:11 OpenSourceSimon