RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

Custom resolution

Open jotonedev opened this issue 3 years ago • 2 comments

Description

Add the option to set a custom resolution for the final video

Issue Fixes

#1176 #943

Checklist:

  • [x] I am pushing changes to the develop branch
  • [x] I am using the recommended development environment
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have formatted and linted my code using python-black and pylint
  • [x] I have cleaned up unnecessary files
  • [x] My changes generate no new warnings
  • [x] My changes follow the existing code-style
  • [x] My changes are relevant to the project

Any other information (e.g how to test the changes)

To test this changes you need to modify the resolution values in the config file.

jotonedev avatar Oct 01 '22 15:10 jotonedev

I'm still working on the custom background resolution.

jotonedev avatar Oct 01 '22 15:10 jotonedev

I definitely wanna see this in version 2.5!

CJthisis avatar Oct 02 '22 20:10 CJthisis

Is this working as of now?

gtxg16 avatar Dec 14 '22 17:12 gtxg16

Is this working as of now?

It is working according to another contributer. I'll test and merge this as soon as possible! Feel free to test it yourself

OpenSourceSimon avatar Dec 14 '22 17:12 OpenSourceSimon