RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

3 util functions for main so the ui looks nicer and 1 bug fix

Open notcooler opened this issue 2 years ago • 1 comments

Description

i added 3 util functions in the main file. getPlatform(), setConsoleSize(), and clear()

getPlatform returns a string according to the platform. setConsoleSize sets console size by the following x and y values. used in the begin so the banner looks nicer :) clear() called before banner prints so it also looks more nicer. 👍

Issue Fixes

There was one issue if the user was using python 3.9 or above and that was that match stament wasnt used anymore in subreddit.py line 44, so changed it to a simple understandable if line. Hope it helps!

Checklist:

  • [ y] I am pushing changes to the develop branch
  • [y ] I am using the recommended development environment
  • [ y] I have performed a self-review of my own code
  • [ y] I have commented my code, particularly in hard-to-understand areas
  • [ y] I have formatted and linted my code using python-black and pylint
  • [ y] I have cleaned up unnecessary files
  • [ y] My changes generate no new warnings
  • [y ] My changes follow the existing code-style
  • [y ] My changes are relevant to the project

Any other information (e.g how to test the changes)

Hope i sent enough info. ;) run and see the changes

notcooler avatar Aug 17 '22 18:08 notcooler

Looks good! But can you remove the fix of the match statement? It is already fixed in the develop branch and now it is causing merge conflicts.

OpenSourceSimon avatar Aug 17 '22 18:08 OpenSourceSimon

all done is it good now?

notcooler avatar Aug 19 '22 18:08 notcooler

fixed it now

notcooler avatar Aug 20 '22 07:08 notcooler

it says i merged develop to master, but i didnt do idk what that is

notcooler avatar Aug 20 '22 07:08 notcooler

it says i merged develop to master, but i didnt do idk what that is

You synchronized the branches. Now it works! @JasonLovesDoggo or @callumio can it be merged?

OpenSourceSimon avatar Aug 20 '22 07:08 OpenSourceSimon

it says i merged develop to master, but i didnt do idk what that is

You synchronized the branches. Now it works! @JasonLovesDoggo or @callumio can it be merged?

I will leave it to Callum

JasonLovesDoggo avatar Aug 20 '22 15:08 JasonLovesDoggo

Is callum busy or... why isnt he responding

notcooler avatar Aug 24 '22 18:08 notcooler

Is Callum busy or... why isn't he responding?

Due to personal circumstances, he is not responding

OpenSourceSimon avatar Aug 25 '22 19:08 OpenSourceSimon

Is Callum busy or... why isn't he responding?

Due to personal circumstances, he is not responding

@StopmotionSimonYT did you actually test it to see it looks fine or just review the code..

JasonLovesDoggo avatar Aug 26 '22 00:08 JasonLovesDoggo

Is Callum busy or... why isn't he responding?

Due to personal circumstances, he is not responding

@StopmotionSimonYT did you actually test it to see it looks fine or just review the code..

I just reviewed the code but I could test it if you want.

OpenSourceSimon avatar Aug 26 '22 06:08 OpenSourceSimon

Is Callum busy or... why isn't he responding?

Due to personal circumstances, he is not responding

@StopmotionSimonYT did you actually test it to see it looks fine or just review the code..

I just reviewed the code but I could test it if you want.

Its simple tho i think you get it by just looking at it- althougj test it if you want

notcooler avatar Aug 26 '22 11:08 notcooler

@StopmotionSimonYT did you actually test it to see it looks fine or just review the code..

I just reviewed the code but I could test it if you want.

Its simple tho i think you get it by just looking at it- althougj test it if you want

Yes the code looks good to me! But can you move the defs to the utils folder and import them in main.py? If that's done I would test it and it could be merged.

OpenSourceSimon avatar Aug 26 '22 12:08 OpenSourceSimon

it should work now. although @StopmotionSimonYT you gotta test it on windows tho since idk if putted the column and line values at the good place for windows.

notcooler avatar Aug 26 '22 13:08 notcooler

The resize resolution is not good on Windows image

OpenSourceSimon avatar Aug 26 '22 14:08 OpenSourceSimon

Anyways i decided to just cancel this rewuest since you guys are developing a gui system as well so i dont really want to work on this anymore. But thanks for all the help. :)

PS - Also sorry i was on vacation i couldnt use github for a while

notcooler avatar Sep 08 '22 08:09 notcooler