Diego Barrios Romero

Results 166 comments of Diego Barrios Romero

@jordens I would say feel free to continue on this if you are still interested.

What do you mean by "stable"? The last published version of this crate implements the original version. I have also implemented version "final 3" (available here) but I have seen...

Interesting. Thanks for letting me know. I will have a look at this soon.

Thank you for this! However, this introduces breaking changes for users so the minor version should be bumped instead of the patch version.

Here is some relevant discussion about this: https://github.com/FluenTech/embedded-time/issues/32

For the record, `unwrap` is used [a total of 4 places](https://github.com/FluenTech/embedded-time/search?q=unwrap&unscoped_q=unwrap) in the _extensive_ library code (excluding documentation, tests and examples) as of now. Replacing with `.operation().ok()` does not sound...

> With embedded-time (or any return value crate) the `.ok()` pattern stops working and one is back to: > > ```rust > let value = if let Ok(value) = interface.operation_with_output()...

I do not have any application to show here. One situation I can think of is: If an I2C device is showing wear signs and starts blocking the bus longer...

Hmm, has anybody looked into why the CI is failing?