ksniff icon indicating copy to clipboard operation
ksniff copied to clipboard

Isolate Sniffers from Ksniff-wide Settings to avoid any side-affects

Open MichaelWasher opened this issue 3 years ago • 0 comments

Sniffers should maintain their own state without fear of changes 'bleeding' out to any global state.

If side-affects come from instantiating a sniffer, this limits the ability to use the sniffers as reusable components. https://github.com/eldadru/ksniff/blob/e299ffb2ec044e21eae9f2d26a3eeb0d637fd617/pkg/service/sniffer/privileged_pod_sniffer_service.go#L31-L44

This PR copies the relevant configuration into the Sniffer internal state. I think there is more that can be done for this (renaming) but I wanted to be as un-invasive as possible.

MichaelWasher avatar Sep 20 '21 02:09 MichaelWasher