Ilia Rassadin

Results 12 comments of Ilia Rassadin

what about such approach https://github.com/mojolicious/mojo/compare/master...elcamlost:Test2?expand=1

Maybe Test::Mojo can be refactored into two packages? One is coupled with Mojolicious and independent from Test framework and another, which loads Test::More and does other work?

[Small gist](https://gist.github.com/elcamlost/d1113885fe0dbda309e00e4e2b1b65ed) to illustrate idea from ^^^

Probable trick with Test::Builder::Level should be rewritten too. See [Test2::Manual::Tooling::Nesting](https://metacpan.org/pod/Test2::Manual::Tooling::Nesting#HOW-TO-FIX-IT).

Created first naive [fork](https://github.com/elcamlost/Test2-Mojo) of Test::Mojo based on Test2. @exodist I'm confused by error handling. If code inside Test2::Mojo dies [like here](https://github.com/elcamlost/Test2-Mojo/blob/master/t/example.t), Test2 [warns](https://gist.github.com/elcamlost/83b682b626464f2e905d93e38de673e7#file-gistfile1-txt-L1-L45) about unreleased context foreach call of...

I finished adopting Test::Mojo code to Test2. [Here it is](https://github.com/elcamlost/Test2-Mojo/blob/master/lib/Test2/Mojo.pm). Of course, it needs documentation too, but code is written and test. BTW, writing tests for tests is surprisingly awesome...

Is Test2::MojoX a good name? On 29/08/2019 00:20, Sebastian Riedel wrote: > > Yes, please use a different namespace than |Test2::Mojo|. We'll keep > that for Mojolicious core in case...

Actually Mojolicious code already depends from external modules (IO::Socket::SSL, Role::Tiny etc), but they marked as optional. Why not add Test2::Suite to this list?

I missed failed XT tests. Apologize. Fixed them now.