yett
yett copied to clipboard
Support to block Iframes
This changes blocks cookies from iframes using the sandbox option.
Hi @amon-ra, thanks a lot for your contribution! 👍
Before we can go in depth and review/evaluate the code/features, could you please:
- provide us with some concrete use case
- add further explanation about the features you are adding - for instance document the api
- make unitary pull requests with one single feature (here I can see at least 2 features at first glance: iframe blocking & unblocking by id)
- make sure that your code contains comments (if needed)
Thanks again, and please let us know when you feel that your PR fullfills these requirements so we can pursue.
Sorry for the late response. I have been working, a link, in a big change to support advanced patterns and block other elements apart of scripts. The syntax used is a string in the form 'element_type:tag/regex/actions'. For example 'iframe:src/blockeddomain/sandbox:allow-scripts' Needs some more testing but it is in a working state. Sorry no to fulfills your requirements but this is one big feature, I will try to document in more detail. Thanks for your work.
Any updates here?