sendgrid-django icon indicating copy to clipboard operation
sendgrid-django copied to clipboard

Added: possibility of adding asm configuration to mail object

Open danniehakan opened this issue 7 years ago • 9 comments

ASM fields in /mail/send v3 endpoint support has been added

Resolves https://github.com/elbuo8/sendgrid-django/issues/72

danniehakan avatar Oct 06 '17 08:10 danniehakan

Codecov Report

Merging #73 into master will increase coverage by 2.75%. The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   65.38%   68.14%   +2.75%     
==========================================
  Files           1        1              
  Lines         104      113       +9     
  Branches       30       33       +3     
==========================================
+ Hits           68       77       +9     
  Misses         29       29              
  Partials        7        7
Impacted Files Coverage Δ
sgbackend/mail.py 68.14% <90.9%> (+2.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b784d5...d7be2ac. Read the comment docs.

codecov-io avatar Oct 06 '17 08:10 codecov-io

Get back if you want to merge this, because at this point I'm beyond this issue in my fork.

danniehakan avatar Oct 27 '17 12:10 danniehakan

@danniehakan Please resolve conflict and I'll merge it.

andriisoldatenko avatar Dec 19 '17 08:12 andriisoldatenko

I've resolved the conflicts.

danniehakan avatar Dec 25 '17 19:12 danniehakan

@danniehakan can you please add small description to documents.

andriisoldatenko avatar Dec 26 '17 10:12 andriisoldatenko

It seems like the build timed out upon dependency installation. It seems to be unrelated to this.

danniehakan avatar Jan 04 '18 10:01 danniehakan

@danniehakan @andriisoldatenko, is there anything that needs to be done before it can be merged? Thanks!

henadzit avatar Oct 18 '18 16:10 henadzit

@andriisoldatenko Hello! Would love to have this merged. If you run the build again I am sure it will pass

janabimustafa avatar Jul 10 '19 06:07 janabimustafa

Just stumbled upon this again. Am I supposed to do anything here? I'm not sure why the build failed, and I don't know if I'm able to re-run the build step.

dhakan avatar Nov 06 '19 12:11 dhakan