Brujo Benavides comments

Results 120 comments of


Brujo Benavides

generate swagger.json on build

Yeah… I would say it should not be _the default app behaviour_. But, if it's clearly optional, we can accept a PR with such changes.

generate swagger.json on build

Sounds good to me

Extend naming conventions with things to avoid

HA! I didn't know about negative lookaheads. I still think that a `forbidden` regex would be clearer and the usual semantics is "allow everything that matches with `regex` *except* if...

New rule: Consistent Trailing Blank Line

Don't forget to add an option to specify the expected trailing line style.

New rule: Consistent Trailing Blank Line

Yeah.

virtual key "$required" was added to build_definition/2

Yes. Go for it, @paulo-ferraz-oliveira

New rule: Redundant Blank Lines

Don't forget to put an option to specify how many lines are too many lines ;)

Formatter remove single quotes from macros containing dashes

@shapovalovts To be honest, nobody is planning to work on this any time soon. The fix probably requires a bunch of non-trivial changes. All for not a huge gain, unless...

Formatting turns function definitions into one long line

It can't "leave it alone" because that's not how this formatter works. This formatter parses the modules into ASTs and then renders them in a formatted way. At the time...

Formatting turns function definitions into one long line

Yeah. That would be possible. We can totally add a config option to _ignore unparseable files entirely_. Do you mind creating a separate ticket for that?