Marco Botto comments

Repositories
Issues
Comments

Results 4 comments of


                                            Marco Botto

UISref links work incorrectly with <base> and hashLocationPlugin

I'm not sure how to reproduce this, as I don't understand if you are serving the app under `localhost:3000/foo`. From the `http://localhost:3000/foo/#/bar` url it looks like it. UI-Router is handling...

UISref links work incorrectly with <base> and hashLocationPlugin

I need to experiment a bit and see what's wrong. Out of curiosity: since you serving from `/foo`, why isn't base ``?

fix(getFilesList) recursively search for files to include

Looks good in general, I think we can make `getFiles` return the array instead of mutating the argument. I can suggest a few changes later in the day!

Typo in the Readme on NPM

🤦‍♀️ Oh, good catch, I think I didn't release a new version on NPM since the fix, so it didn't propagate to Gatsby website :( Will do asap 👍