goproxy icon indicating copy to clipboard operation
goproxy copied to clipboard

Refactor tests

Open ErikPelli opened this issue 1 year ago • 3 comments

Current tests are legacy and really old, no one cared much about them. Failing tests are not reporting the errors to the pipeline result, the whole pipeline should fail, and not report a success.

  1. Try to fix the commented tests (with //), and re-enable them
  2. Rewrite all the tests using testify library (currently used for http1parser_test package)
  3. Refactor the code of the tests to make them more readable

ErikPelli avatar Dec 20 '24 13:12 ErikPelli

@ErikPelli can you assign me this please?

CameronBadman avatar Jan 10 '25 14:01 CameronBadman

sure

ErikPelli avatar Jan 10 '25 14:01 ErikPelli

For the shared proxy functions, like createProxy and all the others that are duplicated, you have to create another package that is imported by all the other tests. Alright @CameronBadman ?

ErikPelli avatar Jan 10 '25 14:01 ErikPelli