Import order to pass linting

[dadgar]

Hey it would be great if the import order followed the go style guide. The side effect of this is that projects that lint fail because of the generated code.

The imports should look like:

package agent

import (
    "bytes"
    "compress/gzip"
    "fmt"
    "io"
    "io/ioutil"
    "os"
    "path/filepath"
    "strings"
    "time"

    "github.com/elazarl/go-bindata-assetfs"
)

[elazarl]

Can you send a PR?

On Thu, Aug 31, 2017, 3:10 AM Alex Dadgar [email protected] wrote:

Hey it would be great if the import order followed the go style guide https://github.com/golang/go/wiki/CodeReviewComments#imports. The side effect of this is that projects that lint fail because of the generated code.

The imports should look like:

package agent

import ( "bytes" "compress/gzip" "fmt" "io" "io/ioutil" "os" "path/filepath" "strings" "time"

"github.com/elazarl/go-bindata-assetfs"

)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/elazarl/go-bindata-assetfs/issues/47, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP4oi1flcpWUm9cA5i6euANifnPeymHks5sdfoKgaJpZM4PIIcc .

[dadgar]

@elazarl Sorry I am not familiar with the code base and glancing through it I couldn't find the relevant part of the code base.

[elazarl]

Unfortunately I don't have much time for this project, and better project exists, e.g., rice.go.

Thanks for the bug report!

On Thu, Aug 31, 2017 at 8:21 PM, Alex Dadgar [email protected] wrote:

@elazarl https://github.com/elazarl Sorry I am not familiar with the code base and glancing through it I couldn't find the relevant part of the code base.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elazarl/go-bindata-assetfs/issues/47#issuecomment-326364479, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP4ouKKe2flDeggiSEdW2pilRhfF8MMks5sdut9gaJpZM4PIIcc .