simply-view-image-for-python-debugging icon indicating copy to clipboard operation
simply-view-image-for-python-debugging copied to clipboard

Feature request: Enchancement of Image watch workflow

Open Cromvell opened this issue 3 years ago • 4 comments

I know it's possible to create new objects in debug console and view them through Image watch. But one's often want to work with arbitrary expression and see what image it resolves to, then change expression in some way, so image would update accordingly. When it's that kind of the process, working with console starts to get inconvenient.

Would it possible to give Image watch view more standard Watch view behavior, when user can enter expressions, and change them on the fly so they would be recomputed? Perhaps, it can be separate type of watch view, from what we currently have, where user can add and delete entries. And current one can be renamed to Image variable view. Or expressions capability could be merged with variables in single Image watch view. Personally, I like the first solution.

The power of general watch feature within it's ability to quickly process expressions. So applied to images, this would make a huge difference.

Cheers.

Cromvell avatar Aug 10 '22 18:08 Cromvell

I love that idea! I would start toying with it, hopefully next week and see what I can get.

There is no option to "rename" a tree view item, so it would have to be somewhere else. My first thought is to use the quickinput top bar for it. What do you think? Alternatively, I can build a custom view where you'll be able to modify the expression (something similar to a notebook cell). But that probably will take me a while to implement, so I guess I'll start with the first idea.

If you have anything else in mind, or anything you'd like to have, please let me know.

Thanks

elazarcoh avatar Aug 10 '22 19:08 elazarcoh

For context, I have no experience in writing VSCode extensions whatsoever, unfortunately. But I'm willing to provide any other help for improving your useful extension.

Quickinput is an easy solution, but again, the power of watch is in the inline expression editing. If standard tree view provider does not support changing labels, which is sucks, the only option I see is to abandon Tree view and make custom view implementation.

Is it possible to adapt Watch expression view from VSCode repo as an extension? That way it could be easier for you to get all functionality like: adding/removing items with different ways, changing expressions inline, dragging and dropping items to change their order. And there's no need to blend it with your current view implementation, as it's actually Image variable view, which is also useful, but in its own ways.

In standard watch and variable views implementation, there's a rendering bug, I guess, with outputting numerical values of big arrays in single line. But as long as we don't need to keep numerical output for images, this not will be a problem.

Cromvell avatar Aug 11 '22 07:08 Cromvell

Would be a gamechanger if we can refrash the variables on change and view them automatically! Just found out about the repo and it's great! LOVE IT!!!

YoniChechik avatar Sep 15 '22 08:09 YoniChechik

Is this feature already implemented by the ability to add expressions to the tree view?

Is there anything else that is currently missing for this feature?

elazarcoh avatar Dec 29 '23 09:12 elazarcoh

This is already implemented. If I missed another request from this thread that is not resolved, please open a new issue.

elazarcoh avatar Sep 10 '24 07:09 elazarcoh