custom-brand-icons icon indicating copy to clipboard operation
custom-brand-icons copied to clipboard

Can't see icons in version update card

Open Sholofly opened this issue 1 year ago • 27 comments

Describe the bug Small but annoying :) When I get an update notification of this wonderfull component the new icons are listed with an image in a table. Unfortunately they always show as an broken image. When I use them in cards or dashboards they show up fine. Cleared the cache opened an incognito window, added the frontend URL but all without any luck

image

Don't see the icon?

It probably depends on the cache. Open Home assistant from an incognito window and check that the icon loads if yes then it depends on the cache, otherwise double check the installation

Sholofly avatar Sep 07 '22 14:09 Sholofly

What version of HACS do you have installed? I think it's a problem with your browser cache. In general the page that I can manage is only related to the release of the versions but as you can see the table is visible correctly. I updated this morning to the new version so I can't take a screenshot but at least in my HA installation the display is correct

elax46 avatar Sep 07 '22 14:09 elax46

Yeah in GitHub it's showing fine too, only in the update screen. Strange thing is that when I go to the img src attribute and opening the direct GitHub link, it's still showing perfectly fine...

Sholofly avatar Sep 07 '22 21:09 Sholofly

In all honesty I do not know if I were you I would check with other browsers, in the next few days a new version will be released we will see if the thing comes up again

elax46 avatar Sep 07 '22 21:09 elax46

Immagine 2022-09-10 153705

Could you also check the issue with different browsers before updating ?, as you can see the display is correct @Sholofly

elax46 avatar Sep 10 '22 13:09 elax46

None of the browser show the images:

tried:

  • Chrome, edge, firefox
  • Enable and disable adguard
  • Add js file to frontend-url in config

Sholofly avatar Sep 13 '22 13:09 Sholofly

Have you updated HACS?

elax46 avatar Sep 13 '22 14:09 elax46

Yup! But I think that was after updating this component.

Sholofly avatar Sep 13 '22 14:09 Sholofly

Have you tried from another device? just not from the same where you tried the various browsers?

elax46 avatar Sep 13 '22 14:09 elax46

Yup been there :) Two laptops and a mobile device.

Sholofly avatar Sep 13 '22 14:09 Sholofly

This thing is really weird, if I were you I would open a problem on HACS also mentioning this one you opened here

elax46 avatar Sep 13 '22 14:09 elax46

Maybe another lead: When I look in your installed repository in HACS the images appear to be broken too. The src of the images = ./icon-svg/bulb-spot-off.svg wich translates to: http://homeassistant.local:8123/hacs/repository/icon-svg/bulb-spot-off.svg

Is that the correct location?

Sholofly avatar Sep 13 '22 15:09 Sholofly

Even stranger. Left column does work right column has other src urls and doesn't

image


Sholofly avatar Sep 13 '22 15:09 Sholofly

This thing is really weird but I see you used inspect by setting the size of a mobile device

elax46 avatar Sep 13 '22 15:09 elax46

Unfortunately size doesnt matter in this case...

Sholofly avatar Sep 13 '22 17:09 Sholofly

Well yes

elax46 avatar Sep 13 '22 20:09 elax46

Well yes

Why?

Sholofly avatar Sep 13 '22 20:09 Sholofly

changing the page size does not change the display of icons is a very strange thing

elax46 avatar Sep 13 '22 21:09 elax46

have you cleared the cache?

rchiileea avatar Sep 14 '22 07:09 rchiileea

Yup, was one of the first steps..

Sholofly avatar Sep 14 '22 07:09 Sholofly

@elax46 Can you do something with this comment?

https://github.com/hacs/integration/issues/2850#issuecomment-1246412852

Sholofly avatar Sep 14 '22 08:09 Sholofly

Already read I will try to settle the matter but it will take some time

elax46 avatar Sep 14 '22 08:09 elax46

NP m8. The problem isn't urgent. Thanks for taking action anyway. Love your work!

Sholofly avatar Sep 14 '22 08:09 Sholofly

In the newly released version I entered the static urls let me know if the icons are visible @Sholofly

Immagine 2022-09-14 132221

elax46 avatar Sep 14 '22 10:09 elax46

Brilliant. Thanks! image

Sholofly avatar Sep 14 '22 11:09 Sholofly

Too quick. The update card works, the repo (after clearing cache and resinstall) doesn't.

Sholofly avatar Sep 14 '22 11:09 Sholofly

At the moment I did a test with the release-only suggestion, the rest will be updated later

elax46 avatar Sep 14 '22 12:09 elax46

I have released a pre-release with the changes if I then install it and let me know if there are any problems thanks

elax46 avatar Sep 15 '22 16:09 elax46

@Sholofly Update on the issue?

elax46 avatar Sep 21 '22 16:09 elax46

Hi @elax46 Sorry for the delayed reply, I've been ill the past week. Updating to 1.0.81b1 doesn't make any difference, still the second column in every table doesn't show the icons.

image

Sholofly avatar Sep 29 '22 09:09 Sholofly

did you clear the cache? with inspect element what do you see? @Sholofly

elax46 avatar Sep 29 '22 16:09 elax46