custom-brand-icons
custom-brand-icons copied to clipboard
elax46
Can't see icons in version update card
Describe the bug Small but annoying :) When I get an update notification of this wonderfull component the new icons are listed with an image in a table. Unfortunately they always show as an broken image. When I use them in cards or dashboards they show up fine. Cleared the cache opened an incognito window, added the frontend URL but all without any luck
Don't see the icon?
It probably depends on the cache. Open Home assistant from an incognito window and check that the icon loads if yes then it depends on the cache, otherwise double check the installation
What version of HACS do you have installed? I think it's a problem with your browser cache. In general the page that I can manage is only related to the release of the versions but as you can see the table is visible correctly. I updated this morning to the new version so I can't take a screenshot but at least in my HA installation the display is correct
Yeah in GitHub it's showing fine too, only in the update screen. Strange thing is that when I go to the img src attribute and opening the direct GitHub link, it's still showing perfectly fine...
In all honesty I do not know if I were you I would check with other browsers, in the next few days a new version will be released we will see if the thing comes up again
Could you also check the issue with different browsers before updating ?, as you can see the display is correct @Sholofly
None of the browser show the images:
tried:
- Chrome, edge, firefox
- Enable and disable adguard
- Add js file to frontend-url in config
Have you tried from another device? just not from the same where you tried the various browsers?
This thing is really weird, if I were you I would open a problem on HACS also mentioning this one you opened here
Maybe another lead: When I look in your installed repository in HACS the images appear to be broken too. The src of the images = ./icon-svg/bulb-spot-off.svg wich translates to: http://homeassistant.local:8123/hacs/repository/icon-svg/bulb-spot-off.svg
Is that the correct location?
Even stranger. Left column does work right column has other src urls and doesn't
This thing is really weird but I see you used inspect by setting the size of a mobile device
changing the page size does not change the display of icons is a very strange thing
@elax46 Can you do something with this comment?
https://github.com/hacs/integration/issues/2850#issuecomment-1246412852
NP m8. The problem isn't urgent. Thanks for taking action anyway. Love your work!
In the newly released version I entered the static urls let me know if the icons are visible @Sholofly
Too quick. The update card works, the repo (after clearing cache and resinstall) doesn't.
At the moment I did a test with the release-only suggestion, the rest will be updated later
I have released a pre-release with the changes if I then install it and let me know if there are any problems thanks
Hi @elax46 Sorry for the delayed reply, I've been ill the past week. Updating to 1.0.81b1 doesn't make any difference, still the second column in every table doesn't show the icons.
