compliantkubernetes-apps icon indicating copy to clipboard operation
compliantkubernetes-apps copied to clipboard

Fix log-manager on Azure

Open vomba opened this issue 1 year ago • 4 comments

[!warning] This is a public repository, ensure not to disclose:

  • [ ] personal data beyond what is necessary for interacting with this pull request, nor
  • [ ] business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • [ ] kind/feature
  • [ ] kind/improvement
  • [ ] kind/deprecation
  • [ ] kind/documentation
  • [ ] kind/clean-up
  • [x] kind/bug
  • [ ] kind/other

Optional: Mark one or more of the following that are applicable:

[!important] Breaking changes should be marked kind/admin-change or kind/dev-change depending on type Critical security fixes should be marked with kind/security

  • [ ] kind/admin-change
  • [ ] kind/dev-change
  • [ ] kind/security
  • [ ] kind/adr

What does this PR do / why do we need this PR?

Updates the az cli commands and template files of log-manager.

  • Fixes #2239

Information to reviewers

Checklist

  • [ ] Proper commit message prefix on all commits
  • Change checks:
    • [ ] The change is transparent
    • [ ] The change is disruptive
    • [ ] The change requires no migration steps
    • [ ] The change requires migration steps
    • [ ] The change upgrades CRDs
    • [ ] The change updates the config and the schema
  • Metrics checks:
    • [ ] The metrics are still exposed and present in Grafana after the change
    • [ ] The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • [ ] The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • [ ] The logs do not show any errors after the change
  • Pod Security Policy checks:
    • [ ] Any changed pod is covered by Pod Security Admission
    • [ ] Any changed pod is covered by Gatekeeper Pod Security Policies
    • [ ] The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • [ ] Any changed pod is covered by Network Policies
    • [ ] The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • [ ] The change does not cause any unnecessary Kubernetes audit events
    • [ ] The change requires changes to Kubernetes audit policy
  • Falco checks:
    • [ ] The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • [ ] The bug fix is covered by regression tests

vomba avatar Aug 29 '24 13:08 vomba

Could you post a listing in ABS before and after a run, and the logs of the run for review please? :pray:

aarnq avatar Aug 29 '24 14:08 aarnq

  • I changed the azure plugin again, it successfully uploads gzipped chunks.
  • LogManager compaction also successfully merges chunks, although it creates additional files somehow. image

vomba avatar Sep 05 '24 12:09 vomba

  • I changed the azure plugin again, it successfully uploads gzipped chunks.

  • LogManager compaction also successfully merges chunks, although it creates additional files somehow.

Check what the list indices function is doing, if it returns multiple entries for the same index.

aarnq avatar Sep 10 '24 06:09 aarnq

  • I changed the azure plugin again, it successfully uploads gzipped chunks.
  • LogManager compaction also successfully merges chunks, although it creates additional files somehow.

Check what the list indices function is doing, if it returns multiple entries for the same index.

Fixed it.

vomba avatar Sep 10 '24 11:09 vomba