Yuri Bocharov
Yuri Bocharov
Fixes #4199 Removes `seed_items: false` from org creation Removes `skip_seed: true` from all specs Removes all code that used the above behaviors. Tests no longer rely on preseeded data! 🥳...
[This test](https://github.com/rubyforgood/human-essentials/blob/9258f16596f341466d7edf11a6373242e061989f/spec/system/distributions_by_county_system_spec.rb#L18) has order dependent failures on main. https://github.com/rubyforgood/human-essentials/actions/runs/8962284988/job/24610951378 Minimal reproduction command: ```console rspec ./spec/requests/account_requests_spec.rb[1:2:3:1,1:3:3:1] ./spec/requests/attachments_requests_spec.rb[1:1:1] ./spec/requests/distributions_requests_spec.rb[1:1:1:1,1:1:2:1,1:1:2:2:1,1:1:3:1,1:1:4:1,1:1:4:2,1:1:4:3,1:1:4:4:1,1:1:5:1,1:1:5:2,1:1:6:1,1:1:6:2:1,1:1:6:3:1,1:1:7:1,1:1:7:2,1:1:7:3:1,1:1:8:1,1:1:9:1:1,1:1:9:1:2,1:1:10:1,1:1:10:2,1:1:10:3,1:1:11:1,1:1:12:1,1:1:12:2:1,1:1:12:2:2,1:1:12:3:1,1:1:12:3:2:1,1:1:12:3:3:1,1:1:13:1,1:1:13:2,1:1:13:3,1:2:1,1:2:2:1:1] ./spec/requests/users_requests_spec.rb[1:1:1,1:2:1,1:3:1,1:3:2,1:3:3,1:3:4,1:4:1:1,1:4:1:2,1:4:2:1] ./spec/system/distributions_by_county_system_spec.rb[1:1:1,1:1:2] ./spec/system/request_system_spec.rb[1:1:1,1:1:2] --seed 48062 ``` Okay, I lied its not the minimal...
This works locally for me. I will be dog-fooding it for a bit. But I think its a nice additional method of setup with minimal work and dependencies. I also...
See https://github.com/rubyforgood/human-essentials/pull/4273#discussion_r1564291195 for full discussion. `rspec ./spec/services/reports/children_served_report_service_spec.rb[1:2:1] --seed 56095` fails on main. `rspec ./spec/services/reports/children_served_report_service_spec.rb --seed 11104` passes. The test is flaky, it is likely related to the items that are...
Related to https://github.com/rubyforgood/human-essentials/issues/4199 Last spec!!! It somehow got missed. ### Type of change * Refactor ### How Has This Been Tested? Passes current suite
Update Nix gemset.
Maybe this will reduce memory consumption? (Is memory consumption even the issue?) `rails assets:precompile` does the equivalent of `yarn:build` + `yarn:build:css` + compiles other assets to serve statically
We have a page `/volunteers` that uses [datatables](https://datatables.net/). This means that sometimes parts of the page don't always load in time when running system tests. Because we had so many...
The partial `volunteers/_send_reminder_button.html.erb` needs fixing.  It has a label(1) and a checkbox(2). They should not be separate. Consider turning the partial into a ViewComponent.
Can create contact types on a case contact that should not be allowed on it. Steps: Volunteer manages cases A and B. Case A => Restrict contact types to just...