terraform-provider-elasticstack
terraform-provider-elasticstack copied to clipboard
elastic
[ISSUE-115] Add Logstash Centralised Pipeline Management
- Add Logstash Centralised Pipeline Management feature, raised under https://github.com/elastic/terraform-provider-elasticstack/issues/115
- ES Logstash API endpoints: https://www.elastic.co/guide/en/elasticsearch/reference/current/logstash-apis.html
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?
@tobio -Please can you take a look at this one when you have a spare sec? Cheers! 👍
Note: First full feature PR so please do shout if there is a better approach i should take with anything defined or if any parts don't make sense!
Looking good, one small comment on the code but really I just want to test some specifics out here before 🍏
Yeah if you are able to test then that would be massively appreciated! 👍 I have been trying to figure out how to define either an empty default or pass through the defaults defined for each setting when the pipeline_settings block is not passed to the provider which has me a bit stumped currently. Seems to populate these defaults for the settings when pipeline_settings {} but when this block doesn't exist I can't seem to figure out how to populate these with each settings default (as setting this is required on the ES API by the looks of it)!
LGTM. Thanks for this! Really appreciate the patience through the review :)
No probs at all! 👍 Thanks for helping throughout the process, am new to Go and provider dev so has been good getting some feedback on better approaches, usage of syntax etc!