terraform-provider-ec icon indicating copy to clipboard operation
terraform-provider-ec copied to clipboard

Remove autoscaling attribute from coordinating and master topology schema.

Open pascal-hofmann opened this issue 2 years ago • 2 comments

Readiness Checklist

  • [x] I am running the latest version
  • [x] I checked the documentation and found no answer
  • [x] I checked to make sure that this issue has not already been filed
  • [x] I am reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

Error messages are inconsistent. I guess master element should not have autoscaling property at all?

Current Behavior

Case 1: If I do not specify an autoscaling element for elasticsearch.master, I get this message:

Inappropriate value for attribute "elasticsearch": attribute "master": attribute "autoscaling" is required.

Case 2: If I do specify it, and set some attributes, I get this:

No autoscaling properties supported for topology element [master] of [elasticsearch]

## Terraform definition Case 1:

master = {}

Case 2:

  master = {
    size = "1g"
    autoscaling = {
      max_size = "1g"
    }
  }

Steps to Reproduce

  1. terraform apply

Your Environment

Terraform v1.3.9
on darwin_amd64
+ provider registry.terraform.io/elastic/ec v0.6.0
+ provider registry.terraform.io/hashicorp/external v2.3.1
+ provider registry.terraform.io/hashicorp/null v3.2.1

and Elastic Cloud Enterprise 3.5.1

pascal-hofmann avatar Mar 09 '23 08:03 pascal-hofmann

Note: The same happens for coordinating instances.

pascal-hofmann avatar Mar 10 '23 08:03 pascal-hofmann

Ideally we'd remove the autoscaling attribute from the schema for those tiers. In the meantime, specifying an empty object should work as expected (there's an acceptance test verifying this exact scenario):

master = {
    size = "1g"
    autoscaling = {}
  }

tobio avatar Aug 03 '23 23:08 tobio