terraform-provider-ec icon indicating copy to clipboard operation
terraform-provider-ec copied to clipboard

Published 20 hours ago • verified publisher icon elastic

fix: remove strategy DiffSuppressFunc

Open kuisathaverat opened this issue 2 years ago • 3 comments

Description

We start using the strategy setting and we realized that the plan does not contain the setting in most of the cases, after checking what happens the cause is the DiffSuppressFunc, it removes the changes in most of the cases. Due to the setting being a transient setting and probably not extended used (probably us only) removing the DiffSuppressFunc does not have any impact.

Related Issues

https://github.com/elastic/terraform-provider-ec/pull/507

Motivation and Context

How Has This Been Tested?

  • We create a cluster with the setting and we try to make some Docker image changes with the strategy setting configured to restart all nodes at the same time. Then we verify the plan does not have the proper configuration.
  • Since then we are using a SNAPSHOT (with this change ) version of the Elastic Terraform provider to update our clusters and work as expected, the plan has the correct strategy configured.

Types of Changes

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Refactoring (improves code quality but has no user-facing effect)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation

Readiness Checklist

  • [X] My code follows the code style of this project
  • [ ] My change requires a change to the documentation
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [X] All new and existing tests passed

kuisathaverat avatar Sep 26 '22 09:09 kuisathaverat

@kuisathaverat , can you please check why acceptance failed

dimuon avatar Oct 04 '22 09:10 dimuon

This test appears to be failing due to https://github.com/hashicorp/terraform-plugin-sdk/issues/1066 and https://github.com/hashicorp/terraform-plugin-sdk/issues/1073 (seem to be duplicates).

I've https://github.com/elastic/terraform-provider-ec/pull/542 the acceptance tests to run against 1.2.9 in CI until the TF issue is fixed.

tobio avatar Oct 05 '22 03:10 tobio

@dimuon The acceptance are passing , I did not change, It looks like was not related to my PR, it have failed at TestAccDeployment_withExtension test

kuisathaverat avatar Oct 05 '22 13:10 kuisathaverat