terraform-provider-ec icon indicating copy to clipboard operation
terraform-provider-ec copied to clipboard

Investigate the effort and benefits of moving to TF Plugin Framework

Open d-carmo opened this issue 3 years ago • 10 comments

Overview

Terraform suggests the use of the TF Plugin Framework. We are currently using the API V2. Lets investigate and see if it is worth to make that move, as well as what is the effort of doing so.

Possible Implementation

Testing

Context

Your Environment

d-carmo avatar Jun 17 '22 14:06 d-carmo

Is someone working on this?

I'm currently looking on fixing #336 ad #466 so no matter which blocks you add or remove from your config, it'll always just work without any useless diff. But it looks like this won't be possible without switching to Terraform Plugin Framework.

pascal-hofmann avatar Aug 15 '22 07:08 pascal-hofmann

I've started working on this but had to switch to more urgent tasks. I'll return to the ticket once these tasks are done.

dimuon avatar Aug 15 '22 09:08 dimuon

@dimuon We decided to work on this as the existing bugs block us. Can you share your current progress?

pascal-hofmann avatar Aug 31 '22 12:08 pascal-hofmann

@pascal-hofmann we’re evaluating needed efforts and prioritising it at the moment.

dimuon avatar Aug 31 '22 14:08 dimuon

Great. So no work is being done twice. :)

-> I've started migrating to framework. The first datasource is nearly working. Will keep you posted on the progress.

pascal-hofmann avatar Aug 31 '22 14:08 pascal-hofmann

@pascal-hofmann thanks for looking into this! We're currently also trying to see what's the path to get the provider to use the plugin framework and are also discussing it with Hashicorp.

If you'd like to contribute work along the lines of this issue - we're happy to get help. But we'll need to balance getting such help with moving as quickly as we can, as this issue is obviously a nuisance to a lot of our customers :)

Kushmaro avatar Aug 31 '22 15:08 Kushmaro

@Kushmaro We just had sprint planning in my team. It was decided that I'll dedicate the next two weeks to migrating terraform-provider-ece to terraform-plugin-framework.

pascal-hofmann avatar Aug 31 '22 15:08 pascal-hofmann

Quick status update: The three existing datasources(ec_deployment, ec_deployments, ec_stack) are already working, I'm starting to convert the resources now.

pascal-hofmann avatar Sep 06 '22 06:09 pascal-hofmann

@pascal-hofmann , would you mind to share a branch with your changes?

dimuon avatar Sep 06 '22 07:09 dimuon

Of course. I just pushed it and created a draft PR: https://github.com/elastic/terraform-provider-ec/pull/529

I just realized the datasources are not fully done - forgot to work on tests in ec/ecdatasource/deploymentdatasource/datasource_test.go. 🙈

pascal-hofmann avatar Sep 06 '22 08:09 pascal-hofmann

Closing as completed. The migration is tracked by #530

dimuon avatar Dec 20 '22 15:12 dimuon