search-ui icon indicating copy to clipboard operation
search-ui copied to clipboard

Correct exports for nuxt/svelte

Open ehibes opened this issue 1 year ago • 8 comments

Description

On Nuxt3 or Svelte projects, an 500 error is returned with this message :

SyntaxError: Named export 'SearchDriver' not found. The requested module '@elastic/search-ui' is a CommonJS module, which may not support all module.exports as named exports.

List of changes

Add correct exports on package.json files to use ESM module on SvelteKit or Nuxt

"exports": {
    ".": {
      "import": "./lib/esm/index.js",
      "require": "./lib/cjs/index.js"
    }
  }
}

Associated Github Issues

Resolve #952 #938 #953

ehibes avatar Jul 17 '23 14:07 ehibes

💚 CLA has been signed

I signed the Contributor Agreement, how to recheck it ?

ehibes avatar Aug 02 '23 07:08 ehibes

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] avatar Oct 01 '23 07:10 botelastic[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] avatar Dec 11 '23 18:12 botelastic[bot]

It looks like this was not merged into the elastic:main @joemcelroy

Finnepinnen avatar Feb 20 '24 14:02 Finnepinnen

Yes, I confirm that it was not merged. Can you reopen this pull request ?

ehibes avatar Feb 29 '24 09:02 ehibes

Is there anything I can do to bump this pull request?

Finnepinnen avatar Mar 20 '24 13:03 Finnepinnen

I'm so excited to get this reviewed!

Finnepinnen avatar May 08 '24 11:05 Finnepinnen

Moved to #1043

miguelgrinberg avatar May 10 '24 09:05 miguelgrinberg