search-ui
search-ui copied to clipboard
FacetContainer: show prop should not apply to all facets
The show prop is hardcoded in FacetContainer, so every facet (View) gets a sliced facetValues array passed as options prop. This is not desirable for facets like SingleSelectFacet, which do not have a mechanism for showing more options by clicking on a "More" link for example. Should the show prop be taken care of by the individual facet components? Or maybe a wider opt-in/opt-out feature for slicing facetValues?
Gitter references
- https://gitter.im/elastic-search-ui/community?at=60cc74bac705e53c1c9b44c0
- https://gitter.im/elastic-search-ui/community?at=60d0a288110daa37b1f9ea00
Addendum
Note that you can work around this "issue" by simply setting show={9999} for example. Although in my opinion, it's not that elegant.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.
willfix