search-ui icon indicating copy to clipboard operation
search-ui copied to clipboard

boolean facet issue

Open ballabusta opened this issue 4 years ago • 5 comments

Hi - would it make sense to differentiate between the facet value name and the label of the facet ? For BooleanFacet component, it's currently the same, say you have the 'In stock' boolean facet, you might want to have a label named 'Status'. Thank you!

ballabusta avatar Apr 30 '21 15:04 ballabusta

Good point. I think the Facet field has a label property, right? So you should be able to customize the facet label.

JasonStoltz avatar May 03 '21 14:05 JasonStoltz

The problem is that the label is also assigned to the facet name, so there is no way to differentiate.

https://github.com/elastic/search-ui/blob/master/packages/react-search-ui-views/src/BooleanFacet.js#L38

I wonder if the facet name can be added as a new prop.

ballabusta avatar May 05 '21 00:05 ballabusta

Ah, I see. That would be better. In the meantime, I would try creating a Custom View.

JasonStoltz avatar May 05 '21 12:05 JasonStoltz

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] avatar Jul 04 '21 12:07 botelastic[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] avatar Sep 04 '21 13:09 botelastic[bot]