search-ui icon indicating copy to clipboard operation
search-ui copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Add a "useSearch" hook as alternative to "withSearch"

Open JasonStoltz opened this issue 6 years ago • 11 comments

This is just a more modern API

zustand has a good example of what our hook might look like:

https://github.com/react-spring/zustand

JasonStoltz avatar May 21 '19 18:05 JasonStoltz

@JasonStoltz I can fix this issue.

m-sureshraj avatar May 26 '19 09:05 m-sureshraj

@m-sureshraj Yes! I'm going to publish a PR very soon for performance issues that will relate to this. So just wait for that PR to merge to avoid conflicts.

JasonStoltz avatar May 28 '19 12:05 JasonStoltz

@m-sureshraj https://github.com/elastic/search-ui/pull/249

JasonStoltz avatar May 28 '19 14:05 JasonStoltz

@JasonStoltz Is there any blockers for this ticket?

m-sureshraj avatar Jun 06 '19 17:06 m-sureshraj

@m-sureshraj No blockers, feel free to work on this. I suggest posting the proposed API for this here for discussion before you get too far along on this task, it could help save you some time on the PR if we have the discussion early.

JasonStoltz avatar Jun 10 '19 11:06 JasonStoltz

Sure @JasonStoltz, I have not yet started the task. I will post the new API changes here for the discussion soon.

m-sureshraj avatar Jun 10 '19 17:06 m-sureshraj

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] avatar Feb 13 '20 14:02 botelastic[bot]

:(

Would love to see this come back up into active development.

calvinl avatar Mar 04 '20 21:03 calvinl

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] avatar May 04 '20 12:05 botelastic[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] avatar May 15 '22 19:05 botelastic[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] avatar Jul 17 '22 15:07 botelastic[bot]