rally icon indicating copy to clipboard operation
rally copied to clipboard

Elastic client now uses url_prefix from host dictionary.

Open RichTeaMan opened this issue 1 year ago • 2 comments

I have several Elastic clusters hosted in a single Kubernetes cluster. For policy reasons, I can only expose port 443. Instead, I use different URL paths to get the right combination of cluster and elastic/kibana. As a result, Rally was failing as --target-hosts would end up stripping most of the URL.

This change checks if a URL prefix has been configured and passes that through in the ES client factory.

I have ran make check-all, the unit tests all work but there are some integration test failures. However, I also get the same failures on master so I'm unsure what to do with them.

I have signed the contributor agreement.

RichTeaMan avatar Aug 03 '24 16:08 RichTeaMan

Thanks for the contribution - Yes, the integration tests require some API keys etc, so tend to be run via the CI. I unblocked the CI for your changes, so lets let them run there and see.

gareth-ellis avatar Aug 06 '24 13:08 gareth-ellis

Buildkite test this please

gareth-ellis avatar Aug 07 '24 07:08 gareth-ellis

@elasticmachine update branch

gbanasiak avatar May 21 '25 15:05 gbanasiak

Buildkite test this please

gbanasiak avatar May 21 '25 15:05 gbanasiak

Buildkite test this please

gbanasiak avatar May 21 '25 16:05 gbanasiak