otel-profiling-agent icon indicating copy to clipboard operation
otel-profiling-agent copied to clipboard

Go labels from pprof labels

Open gnurizen opened this issue 8 months ago • 3 comments

Add support for a collection of 10 labels that can be attached to every sample. Process the go pprof labels into these labels.

Test that this works for Go 1.23 and Go 1.24 with new kernel tests.

Co-authored-by: umanwizard [email protected]

gnurizen avatar Mar 18 '25 17:03 gnurizen

Rebased and squashed to hopefully make further review and rebasing easier. Thanks for all the reviews so far!

gnurizen avatar Apr 09 '25 00:04 gnurizen

This is ready for another look, I think all review concerns were addressed, thanks for checking it out!

gnurizen avatar May 05 '25 19:05 gnurizen

@florianl and @fabled did you guys have any more concerns about this? If we think it needs more bake time can we look at merging it disabled to avoid further rebasing/merge hassles?

gnurizen avatar May 15 '25 17:05 gnurizen

Also just merged a new EBPF_INLINE in #470. Could you also apply the rules from the commit message for using EBPF_INLINE and inline?

fabled avatar May 27 '25 10:05 fabled

Okay some dynamic offset lookups were required to get static cgo binaries to work on amd64 and arm64. I separated out those changes in separate commits which hopefully makes it easier to review. Ready for another look! Thanks in advance.

gnurizen avatar May 29 '25 21:05 gnurizen

Thanks @fabled! Rebased and addressed all comments, I'll make a TODO to look at the pclntab stuff. @florianl can you give this another gander? Thanks!

gnurizen avatar Jun 19 '25 20:06 gnurizen