otel-profiling-agent icon indicating copy to clipboard operation
otel-profiling-agent copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Clang 18 inline failure

Open gnurizen opened this issue 1 year ago • 1 comments

Clang 18 fails to produce a working unwinder because the event_send_trigger function isn't inlined and the 5.4 kernels complain about bpf calls and bpf-tail calls both being present not being allowed. I guess "static inline" isn't strong enough and we need to break out the always_inline attribute?

Proposal:

  1. Use static inline attribute((always_inline))
  2. Create an OPTI_INLINE macro that expands to this use that everywhere

gnurizen avatar Nov 04 '24 17:11 gnurizen

Can you give more details about your clang version and architecture? Because this issue is not reproducible here :)

$ clang-18 --version
Debian clang version 18.1.8 (12)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

$ uname -a
Linux P15v 6.11.4-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.11.4-1 (2024-10-20) x86_64 GNU/Linux

rockdaboot avatar Nov 05 '24 06:11 rockdaboot