arcsight module: passthrough kafka and tcp options (WIP)

[yaauie]

Target: master, 6.x

Resolves: elastic/logstash#9746

Passthrough options from Kafka- and TCP-Input Plugins to the Arcsight Module, in order to add support for TLS/SSL that are already available in the plugins to the module.

At this point I'm looking for feedback on general approach.

TODO:

• [ ] documentation: since we are passing through these options directly to the respective input plugin without providing additional defaults, and we avoid talking about the Event Broker as Kafka in the docs or the SmartConnector as TCP in the docs, I'm not sure the best way to document without duplicating everything in the respective plugins.
• [ ] tests: there are a lot of combinations of settings that are available, and I will need find the right way to add tests that validate the intended behaviour, since the module currently does not have any tests

[karenzone]

@karenzone. Take a look with an eye toward this:

documentation: since we are passing through these options directly to the respective input plugin without providing additional defaults, and we avoid talking about the Event Broker as Kafka in the docs or the SmartConnector as TCP in the docs, I'm not sure the best way to document without duplicating everything in the respective plugins.

[acchen97]

@karenzone I think we can probably just list the options again in the ArcSight module docs, similar to what we did with the Azure module config options. We'd have to find a way (or be diligent) around updating these module options if the underlying plugin options change. I'd expect these changes to be relatively uncommon given most of these options are quite stable at this juncture.

[acchen97]

@yaauie @guyboertje should we be closing this given it looks like it's been superseded by @guyboertje PR?

https://github.com/elastic/logstash/pull/10056

[guyboertje]

Damn, I didn't check whether Ry had done any work already.

[mergify[bot]]

This pull request does not have a backport label. Could you fix it @yaauie? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
• backport-8.x is the label to automatically backport to the 8.x branch.

[mergify[bot]]

backport-8.x has been added to help with the transition to the new branch 8.x. If you don't need it please use backport-skip label.

[mergify[bot]]

This pull request is now in conflicts. Could you fix it @yaauie? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b arcsight-module-config-passthrough upstream/arcsight-module-config-passthrough
git merge upstream/main
git push upstream arcsight-module-config-passthrough