logstash Fix destination port normalization in case of udp

This change addresses the destination port normalization in case of UDP protocol. In that if/else clause you want to populate the dst port but for doing that you check the udp_src port's existence. That said, I believe that it will not hurt in any case but it's not correct from a logical point of view: "you check the existence of a field, but then you use another field"

Sep 14 '17 08:09 vpiserchia

Can one of the admins verify this patch?

Sep 14 '17 08:09 elasticmachine

Can you add more details of why you are suggesting these changes? Also, I'll close your other PRs since we target master and backport to branches.

Sep 14 '17 15:09 suyograo

@suyograo about details I've updated the original comment; I hope this works for you. regards

Sep 15 '17 07:09 vpiserchia

jenkins, please test this

Feb 07 '18 23:02 andrewvc

@vpiserchia this change looks good to me, but we'll need you to sign the CLA first! Can you visit: http://www.elasticsearch.org/contributor-agreement/ and do so?

Feb 07 '18 23:02 andrewvc

@andrewvc I've filed the CLA

Feb 08 '18 08:02 vpiserchia

jenkins, please test this

Feb 08 '18 20:02 andrewvc

@vpiserchia can you rebase and force push to update your branch as well? This got a little stale, it would help our build system.

Also, did you make sure to sign the CLA with the same email that's on your github account/git commits?

Feb 08 '18 20:02 andrewvc

@andrewvc rebased against master also it uses the same email used for the CLA

Feb 12 '18 14:02 vpiserchia

This pull request does not have a backport label. Could you fix it @vpiserchia? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
backport-8.x is the label to automatically backport to the 8.x branch.

Mar 05 '25 20:03 mergify[bot]

backport-8.x has been added to help with the transition to the new branch 8.x. If you don't need it please use backport-skip label.

Mar 05 '25 20:03 mergify[bot]

This pull request is now in conflicts. Could you fix it @vpiserchia? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/main
git push upstream master

Mar 05 '25 20:03 mergify[bot]

not sure why I should spend time on this anymore. you have the patch, fix it

Mar 05 '25 22:03 vpiserchia