logstash icon indicating copy to clipboard operation
logstash copied to clipboard

Minor, added some methods to ReadDemand that would increase readability

Open andsel opened this issue 5 months ago • 4 comments

Release notes

[rn:skip]

What does this PR do?

Adds a couple of helper methods to ReadDemand inner class in PQ to improve readability and make explicit the intent of the code.

Why is it important/What is the impact to the user?

AS a developer I want the code to be as smooth as possible.

Checklist

  • [x] My code follows the style guidelines of this project
  • ~~[ ] I have commented my code, particularly in hard-to-understand areas~~
  • ~~[ ] I have made corresponding changes to the documentation~~
  • ~~[ ] I have made corresponding change to the default configuration files (and/or docker env variables)~~
  • ~~[ ] I have added tests that prove my fix is effective or that my feature works~~

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

  • Relates #17765

andsel avatar Jul 10 '25 08:07 andsel

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

github-actions[bot] avatar Jul 10 '25 08:07 github-actions[bot]

This pull request does not have a backport label. Could you fix it @andsel? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

mergify[bot] avatar Jul 10 '25 08:07 mergify[bot]

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

elastic-sonarqube[bot] avatar Jul 11 '25 07:07 elastic-sonarqube[bot]

:green_heart: Build Succeeded

History

  • :yellow_heart: Build #3111 was flaky c51c116f8e2ad9ea9190ac56b81e4c3e1ea2470a

elasticmachine avatar Jul 11 '25 07:07 elasticmachine