kibana
kibana copied to clipboard
[Inventory][ECO] Entities Group By View
Summary
This PR introduces the API and Page for doing grouped views for the Inventory Page. Alongside the plain list view, the page now by default shows a grouped view of entities. In this PR, the only current supported grouping is by Entity Type.
https://github.com/user-attachments/assets/a07db592-d6c6-4ec1-a00b-bb469908aa6a
Tests TBA
How to test
- Navigate to the new Inventory Page
- By default, the page should load into a grouped view (Type)
- The page should show all entities currently grouped by their type.
- If a group has enough entities, pagination navigation should only apply to the list within the group.
- The plain list view should function same as before.
- Using the search/filter bar should function the same with grouped and list view.
Closes #194740
@elasticmachine merge upstream
@elasticmachine merge upstream
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)
:robot: GitHub comments
Expand to view the GitHub comments
Just comment with:
/oblt-deploy: Deploy a Kibana instance using the Observability test environments.rundocs-build: Re-trigger the docs validation. (use unformatted text in the comment!)
Groups are not being filtered by entity type and kql:
@cauemarcondes @crespocarlos The lazy loading is in place, and it also won't retrigger an API call if the accordion was closed and then reopened.
@elasticmachine merge upstream
@elasticmachine merge upstream
@elasticmachine merge upstream
Following up on this comment https://github.com/elastic/kibana/pull/195475#discussion_r1814570767
With a URL like this inventory/?pagination=%28container%3A2%29&sortDirection=desci&sortField=alertsCount&view=grouped
passing sortDirection=desciii
Causes the UI to crash.
@crespocarlos This bug/crash exists on main, so the PR didn't introduce the crashing for invalid sortDirection fields. I would say that then would be out of scope for this PR to fix that and we could add this as an additional follow-up issue.
/ci
@elasticmachine merge upstream
/ci
:yellow_heart: Build succeeded, but was flaky
- Buildkite Build
- Commit: 0886259e1b6a8652e10e0f7d489d1ed0159d0dba
- Kibana Serverless Image:
docker.elastic.co/kibana-ci/kibana-serverless:pr-195475-0886259e1b6a
Failed CI Steps
Test Failures
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
inventory |
228 | 235 | +7 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
inventory |
219.1KB | 230.2KB | +11.1KB |
Public APIs missing exports
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0.
Run node scripts/build_api_docs --plugin [yourplugin] --stats exportsfor more detailed information.
| id | before | after | diff |
|---|---|---|---|
inventory |
3 | 4 | +1 |
Unknown metric groups
ESLint disabled line counts
| id | before | after | diff |
|---|---|---|---|
inventory |
1 | 2 | +1 |
Total ESLint disabled count
| id | before | after | diff |
|---|---|---|---|
inventory |
5 | 6 | +1 |
History
- :green_heart: Build #246905 succeeded 0886259e1b6a8652e10e0f7d489d1ed0159d0dba
- :green_heart: Build #246876 succeeded 1514c409e0578353ac26c1ed0d2fb3f3558993e8
- :broken_heart: Build #246692 failed 1514c409e0578353ac26c1ed0d2fb3f3558993e8
- :green_heart: Build #246660 succeeded 8d216b2dfa7b4182dbf31234c89d7aad04e58046
- :green_heart: Build #246222 succeeded 8ca25d2bc0e1e32546e92dca23da9127b3cdd652