elastic
Assign Roles to Space from Spaces Management
Summary
Epic link: https://github.com/elastic/kibana-team/issues/785
This changes bring a new design to the management of Spaces in Stack Management / Security. We have a new page to view the details of the Space, and new UX to assign Roles to a Space.
Release Note
Added several UX improvements to the management of Spaces in Stack Management > Spaces, including the ability to assign Roles to an existing Space.
Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [x] Unit or functional tests were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [x] This was checked for cross-browser compatibility
@azasypkin @elena-shostak
Thanks for your diligent review, Eyo and I have resolved most of the feedback that you have graciously provided. I think the last topic for discussion is this question: https://github.com/elastic/kibana/pull/191795/files#r1754033533. I have opened a thread in Slack for the team to discuss that offline.
Would you both mind double-checking and make sure we have taken care of the addressable items?
Flaky Test Runner Stats
🎉 All tests passed! - kibana-flaky-test-suite-runner#6953
[✅] x-pack/test/functional/apps/spaces/config.ts: 50/50 tests passed. [✅] x-pack/test/functional/apps/spaces/solution_view_flag_enabled/config.ts: 50/50 tests passed.
:broken_heart: Build Failed
- Buildkite Build
- Commit: ae734057271bccdb3aeb5b2985dad918f04ea492
- Interpreting CI Failures
Failed CI Steps
Test Failures
- [job] [logs] Jest Tests #9 / Create renders correctly with optional fields
- [job] [logs] FTR Configs #98 / discover/context_awareness extension getDocViewer data view mode should not render logs overview tab for non-logs data source
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
spaces |
272 | 332 | +60 |
Public APIs missing comments
Total count of every public API that lacks a comment. Target amount is 0. Run
node scripts/build_api_docs --plugin [yourplugin] --stats commentsfor more detailed information.
| id | before | after | diff |
|---|---|---|---|
@kbn/security-plugin-types-public |
31 | 39 | +8 |
@kbn/security-ui-components |
12 | 13 | +1 |
spaces |
67 | 71 | +4 |
| total | +13 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
security |
590.0KB | 591.2KB | +1.2KB |
spaces |
184.2KB | 256.6KB | +72.4KB |
| total | +73.6KB |
Public APIs missing exports
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0.
Run node scripts/build_api_docs --plugin [yourplugin] --stats exportsfor more detailed information.
| id | before | after | diff |
|---|---|---|---|
spaces |
0 | 1 | +1 |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
security |
67.4KB | 67.6KB | +246.0B |
spaces |
29.8KB | 30.8KB | +1.0KB |
| total | +1.3KB |
Unknown metric groups
API count
| id | before | after | diff |
|---|---|---|---|
@kbn/security-plugin-types-public |
58 | 66 | +8 |
@kbn/security-ui-components |
47 | 48 | +1 |
spaces |
262 | 266 | +4 |
| total | +13 |
async chunk count
| id | before | after | diff |
|---|---|---|---|
spaces |
11 | 16 | +5 |
History
- :broken_heart: Build #235371 failed 385d2a1be6660be6de5e79836204e2807416ee0a
- :broken_heart: Build #235297 failed bdc1a5c18ec3c2dffbbb168783def1878db34f8c
- :broken_heart: Build #234995 failed a1e533e883c325b65d967808b05e69a410ce7466
- :broken_heart: Build #234725 failed fc40515d031e30dc9e60ccd34004ad36b24a79b5
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @tsullivan @eokoneyo
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 8.x |  |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation