kibana icon indicating copy to clipboard operation
kibana copied to clipboard

Replacement of link-to links with infra locators

Open Bluefinger opened this issue 1 year ago • 3 comments

Summary

Replacing link-to urls with infra locators, so that we can deprecate link-to for infra.

TODOs

  • [x] Host-link component replaced with locator usage
  • [ ] E2E test changes

Checklist

Delete any items that are not applicable to this PR.

  • [ ] Unit or functional tests were updated or added to match the most common scenarios
  • [ ] Flaky Test Runner was used on any tests changed
  • [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/

For maintainers

Bluefinger avatar Aug 28 '24 08:08 Bluefinger

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

obltmachine avatar Aug 28 '24 08:08 obltmachine

/ci

Bluefinger avatar Aug 28 '24 10:08 Bluefinger

/ci

Bluefinger avatar Aug 28 '24 16:08 Bluefinger

Hey @Bluefinger , about the infra link-to routes, could we mark them as deprecated (example)?

crespocarlos avatar Aug 29 '24 11:08 crespocarlos

/ci

Bluefinger avatar Aug 29 '24 14:08 Bluefinger

@elasticmachine merge upstream

Bluefinger avatar Aug 29 '24 16:08 Bluefinger

/ci

Bluefinger avatar Aug 29 '24 16:08 Bluefinger

@elasticmachine merge upstream

Bluefinger avatar Sep 02 '24 08:09 Bluefinger

/ci

Bluefinger avatar Sep 02 '24 09:09 Bluefinger

/ci

Bluefinger avatar Sep 02 '24 12:09 Bluefinger

/ci

Bluefinger avatar Sep 02 '24 14:09 Bluefinger

@elasticmachine merge upstream

Bluefinger avatar Sep 03 '24 09:09 Bluefinger

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine avatar Sep 03 '24 11:09 elasticmachine

@elasticmachine merge upstream

Bluefinger avatar Sep 04 '24 08:09 Bluefinger

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

elasticmachine avatar Sep 04 '24 08:09 elasticmachine

@elasticmachine merge upstream

Bluefinger avatar Sep 05 '24 08:09 Bluefinger

@elasticmachine merge upstream

Bluefinger avatar Sep 06 '24 08:09 Bluefinger

@elasticmachine merge upstream

Bluefinger avatar Sep 06 '24 14:09 Bluefinger

@elasticmachine merge upstream

Bluefinger avatar Sep 09 '24 08:09 Bluefinger

:yellow_heart: Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 5b11fab579e8ac931c5494bf380313a8373d2e04
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191578-5b11fab579e8

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #104 / Journey[apm_service_inventory] "before all" hook for "Navigate to Service Inventory Page"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1872 1871 -1
infra 1503 1502 -1
total -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityShared 452 453 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +53.0B
infra 1.6MB 1.6MB -3.0B
observability 463.2KB 463.4KB +218.0B
uptime 468.0KB 468.2KB +176.0B
total +444.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 51.2KB 51.1KB -109.0B
observabilityShared 69.5KB 69.7KB +254.0B
uptime 22.6KB 22.8KB +149.0B
total +294.0B
Unknown metric groups

API count

id before after diff
observabilityShared 457 458 +1

History

  • :green_heart: Build #232517 succeeded c6e2a1aad554ad5b4c4ee8b57372cd471122d0a5
  • :green_heart: Build #232482 succeeded 719d17f3f5702f1c64a7851e0cddbf7e1f62a9ca
  • :broken_heart: Build #232384 failed 4abfea17466541019d8895216ff8c21a84bb145c
  • :broken_heart: Build #232208 failed 770848bc0f1d828ccd829e75d6aae438c68e99c6
  • :broken_heart: Build #232140 failed 1b64c7a632da162c84b438776f2f56c99ff82470

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @Bluefinger

kibana-ci avatar Sep 09 '24 09:09 kibana-ci