elastic
[Ingest Pipelines] Add Manage processors page
Fixes https://github.com/elastic/kibana/issues/190818
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Flaky Test Runner was used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---|---|---|---|
| Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
| Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
| See more potential risk examples |
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
:broken_heart: Build Failed
- Buildkite Build
- Commit: da89cfd5d81aea900ec2cdc8dff33c2c6ce0657a
- Interpreting CI Failures
- Cloud Deployment
Failed CI Steps
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
ingestPipelines |
327 | 335 | +8 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
ingestPipelines |
375.1KB | 386.5KB | +11.4KB |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
ingestPipelines |
16.7KB | 17.4KB | +757.0B |
History
- :broken_heart: Build #231229 failed e44105e1e4f228559bb209736f09f3fd55a33bbc
- :broken_heart: Build #231058 failed 31a5b40abdf7684f2726058e22b74f992f538e35
- :yellow_heart: Build #230811 was flaky 943683b32b8d5838fcced5f6b410d3203541520f
- :yellow_heart: Build #230376 was flaky e9bbe830cf5f7c140d774f4595bf02c7c1dcc0e4
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
Thanks for the review @ElenaStoeva!
- In the PR description I see that the "Database file" field in the Add processor form has a dropdown with all available processors, but I don't see this when I run locally. Has this been changed?
The geoip processor will remain the same, only the new IP location processor has the dropdown that allows you to select the database
Will this be resolved from Es side? Also, I wonder if we could make the error message more readable in case there is an error.
Still waiting on their confirmation on which are the right keys, this validation error is on our side so maybe theres something we could initially do for it
- Regarding the privileges, I tried testing the "read-only" view where the "Manage processors" button is not displayed, but when I only add the
read_pipelinerole, I'm not able to view the Ingest pipelines app at all (probably because it doesn't have a read-only view?). How did you test this, what privileges did you use?
In order to see and use Ingest Pipelines you need two privileges: manage_pipeline and cluster:monitor/nodes/info. If you want to also see the Manage processors link, you also need to have the manage permission.
:green_heart: Build Succeeded
- Buildkite Build
- Commit: 69ee5303cfbaa2126e0009177ecf84ba586fef17
- Cloud Deployment
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
ingestPipelines |
329 | 339 | +10 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
ingestPipelines |
375.4KB | 392.6KB | +17.2KB |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
ingestPipelines |
16.7KB | 17.5KB | +845.0B |
History
- :broken_heart: Build #242625 failed 372bbf121f56fc51284af15879006002e73ffef3
- :broken_heart: Build #242562 failed d108302bc5b9566cac83ccd67a180581bdf143e6
- :broken_heart: Build #242509 failed ccc25bcf86e12e55f6cc11a451e464abd27eb2af
- :broken_heart: Build #242349 failed 7228df792de78db2bd20514e86d57acb73d92bd9
- :broken_heart: Build #242324 failed c69902e3fc1cd377b6eb491911e7dbe1d17fa30e
cc @sabarasaba @ElenaStoeva
Starting backport for target branches: 8.x
https://github.com/elastic/kibana/actions/runs/11351709960
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 8.x |  |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation